]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
shell-window-tracker: Fix signal handler leak
authorAdel Gadllah <adel.gadllah@gmail.com>
Sun, 12 Jun 2011 12:03:18 +0000 (14:03 +0200)
committerAdel Gadllah <adel.gadllah@gmail.com>
Mon, 13 Jun 2011 15:04:22 +0000 (17:04 +0200)
Disconnect the on_wm_class_changed handler when removing a window
in disassociate_window().

https://bugzilla.gnome.org/show_bug.cgi?id=652388

src/shell-window-tracker.c

index 9811245949866446e36c0c93acfdf81dc61c0d9e..4b7b2d4eba9a1ef1f90263e0f0cdb011966f4875 100644 (file)
@@ -487,7 +487,10 @@ disassociate_window (ShellWindowTracker   *self,
   g_hash_table_remove (self->window_to_app, window);
 
   if (shell_window_tracker_is_window_interesting (window))
+    {
       _shell_app_remove_window (app, window);
+      g_signal_handlers_disconnect_by_func (window, G_CALLBACK(on_wm_class_changed), self);
+    }
 
   g_signal_emit (self, signals[TRACKED_WINDOWS_CHANGED], 0);